Filter Friday deadlines to cycle initiative projects #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Filters the "Projects Due Friday" Slack notification to only include projects associated with a specific cycle initiative, reducing noise by focusing on relevant projects for the current cycle.
- Adds filtering logic to
post_friday_deadlines()function to check for cycle initiative configuration - Filters projects based on initiative nodes matching the configured cycle initiative name
jobs.py
Outdated
Comment on lines
342
to
345
| if any( | ||
| node.get("name") == cycle_init | ||
| for node in p.get("initiatives", {}).get("nodes", []) | ||
| ) |
There was a problem hiding this comment.
[nitpick] The nested list comprehension with any() creates complex logic that's hard to read. Consider extracting the filtering logic into a separate helper function for better maintainability.
Suggested change
| if any( | |
| node.get("name") == cycle_init | |
| for node in p.get("initiatives", {}).get("nodes", []) | |
| ) | |
| if has_initiative(p, cycle_init) |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
flake8 *.pymypy .https://chatgpt.com/codex/tasks/task_e_6899ddedcd8483249874c1bfdbf40f68